fix: correct height and position for inner element #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chintankavathia
force-pushed
the
fix/wrapper-element-height
branch
from
23beb97 to
5d3a0d3
Compare
|
Not sure, if this is really the correct fix. In my opinion the actual problem here is, that this is a component, while it should be at a directive.or maybe even just merged into the datatable-scroller which itself should not be a component either. |
chintankavathia
force-pushed
the
fix/wrapper-element-height
branch
from
5d3a0d3 to
62aafd5
Compare
chintankavathia
requested review from
spike-rabbit
and removed request for
timowolf
chintankavathia
force-pushed
the
fix/wrapper-element-height
branch
3 times, most recently
from
2800458 to
9735588
Compare
BREAKING CHANGE: replaced `DataTableSelectionComponent` with `DataTableSelectionDirective` and `ScrollerComponent` with `ScrollerDirective`. This components were used internally and now replaced as directives.
chintankavathia
force-pushed
the
fix/wrapper-element-height
branch
from
9735588 to
23addae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix
datatable-selectionelement which is not correctly getting height and position.steps:
datatable-selectionelement in DOMWhat kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: