Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update group checkbox state on child row selection state change #118

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

chintankavathia
Copy link
Member

What kind of change does this PR introduce? (check one with "x")

Steps:

  • go to row-grouping example

  • select all the rows from a specific group

  • checkbox in the group state changes to checked

  • now un select one of the row from the group

  • checkbox in the group remains checked even though all rows under that groups are not selected

  • Bugfix

  • Feature

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@chintankavathia chintankavathia marked this pull request as ready for review November 11, 2024 09:40
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timowolf timowolf merged commit 11389bc into siemens:master Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants