fix: do not bind content as innerHTML by default
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Previously, cell values were bound using `innerHTML`. With this change they are now bound using normal data binding. This means that any html markup will no longer be rendered. To restore the previous behavior set `bindAsUnsafeHtml` on columns where needed. We decided to change this behavior, as binding `innerHTML` can lead to HTML injection. Especially in table content which are often untrusted user generated content. BREAKING CHANGE: Header cell names are now bound using data binding instead of `innerHTML`. Use a `headerTemplate` to provide custom html markup.
timowolf
approved these changes
Nov 20, 2024
fh1ch
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
@spike-rabbit outstanding work with the MR here, thanks a ton 🙇
The changes look flawless and my local verification tests were all successful. Also nice work with the inline documentation. So let's get this one in.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Previously, cell values were bound using
innerHTML. With this change they are now bound using normal data binding. This means that any html markup will no longer be rendered. To restore the previous behavior setbindAsUnsafeHtmlon columns where needed.We decided to change this behavior,
as binding
innerHTMLcan lead to HTML injection. Especially in table content which are often untrusted user generated content.BREAKING CHANGE:
Header cell names are now bound using data binding instead of
innerHTML.Use a
headerTemplateto provide custom html markup.What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: