Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/angular 17 #41

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Feat/angular 17 #41

merged 5 commits into from
Dec 18, 2023

Conversation

fh1ch
Copy link
Member

@fh1ch fh1ch commented Dec 13, 2023 •
edited
Loading

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

The project uses Angular 15 for the main demo app.

What is the new behavior?

The project uses Angular 17 for the main demo app.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Also bumps the minimal required Angular version to 17.0 and rxjs version to 7.8.0 using a breaking change in feca9fa.

fh1ch added 3 commits December 12, 2023 17:03
@fh1ch
feat(angular): update project to Angular 16
6144cb5 
Updated using `ng update @angular/core@16 @angular/cli@16 @angular-eslint/schematics@16`.
@fh1ch
feat(angular): update project to Angular 17
d5c13a4 
Updated using `ng update @angular/core@17 @angular/cli@17 @angular-eslint/schematics@17`.
@fh1ch
chore(eslint): back-merge breaking upstream changes
e2171c1
@fh1ch fh1ch added the enhancement New feature or request label Dec 13, 2023
@fh1ch fh1ch self-assigned this Dec 13, 2023
@timowolf timowolf self-requested a review December 13, 2023 09:00
@timowolf
Copy link
Member

@fh1ch Many thanks for updating. Let me know when ready for review.

@fh1ch
Copy link
Member Author

fh1ch commented Dec 13, 2023

@timowolf @kfenner this PR is more or less ready and updates the project setup to Angular 17. The only remaining question is, if we should bump the minimal peer-dep version within https://github.com/siemens/ngx-datatable/blob/master/projects/ngx-datatable/package.json#L6-L12 and probably also mark this as a breaking change. WDYT?

@timowolf
Copy link
Member

@fh1ch Yes, let us do so.

@fh1ch
refactor(npm): bump peerDependencies to Angular 17 and rxjs 7.8
feca9fa 
BREAKING CHANGE: Requires at least Angular 17.0 and rxjs 7.8.0.
@fh1ch fh1ch marked this pull request as ready for review December 13, 2023 17:53
@fh1ch fh1ch assigned timowolf and unassigned fh1ch Dec 13, 2023
@fh1ch
Copy link
Member Author

fh1ch commented Dec 13, 2023

@fh1ch Many thanks for updating. Let me know when ready for review.

We're ready to role here. Back to you 🏓

@kfenner
Copy link
Collaborator

kfenner commented Dec 13, 2023

@timowolf @kfenner this PR is more or less ready and updates the project setup to Angular 17. The only remaining question is, if we should bump the minimal peer-dep version within https://github.com/siemens/ngx-datatable/blob/master/projects/ngx-datatable/package.json#L6-L12 and probably also mark this as a breaking change. WDYT?

@fh1ch @timowolf Is there any need for this, or even any benefit right now? If we need to fix a bug or something, only apps on Angular 17 will be able to use it...

@timowolf
Copy link
Member

@timowolf @kfenner this PR is more or less ready and updates the project setup to Angular 17. The only remaining question is, if we should bump the minimal peer-dep version within https://github.com/siemens/ngx-datatable/blob/master/projects/ngx-datatable/package.json#L6-L12 and probably also mark this as a breaking change. WDYT?

@fh1ch @timowolf Is there any need for this, or even any benefit right now? If we need to fix a bug or something, only apps on Angular 17 will be able to use it...

I think it is fine. They can use it anyway but get a warning. This opens up for using ng17 features.

timowolf
timowolf approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Many thanks.

@timowolf timowolf merged commit d6e8c3a into master Dec 18, 2023
1 check passed
jarno-zeron added a commit to zeron-be/ngx-datatable that referenced this pull request May 24, 2024
@jarno-zeron
Revert "Feat/angular 17 (siemens#41)"
fc333ae 
This reverts commit d6e8c3a.
sp-eric-pinto added a commit to sp-eric-pinto/ngx-datatable that referenced this pull request Jun 4, 2024
@sp-eric-pinto
Revert "Feat/angular 17 (siemens#41)"
64a34f7 
This reverts commit d6e8c3a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timowolf timowolf timowolf approved these changes

Assignees

@timowolf timowolf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fh1ch @timowolf @kfenner