Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: proper types for rows (#46)" #48

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

spike-rabbit
Copy link
Collaborator

@spike-rabbit spike-rabbit commented Apr 29, 2024

This reverts commit 1641b94.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@timowolf timowolf self-requested a review April 29, 2024 11:46
Copy link
Member

@timowolf timowolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting the type addition as we introduced a breaking change. We will create a fix release and add the types in a breaking change again. Many thanks.

@timowolf timowolf merged commit 2d7244f into master Apr 29, 2024
1 check passed
@timowolf timowolf deleted the fix/revert-types branch April 29, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants