Skip to content

Commit

Permalink
fixup! fixup! X509_dup.pod: add caveat that extra data is not copied …
Browse files Browse the repository at this point in the history
…and hints, e.g., to use X509_up_ref() instead
  • Loading branch information
DDvO committed Jan 17, 2024
1 parent 806075f commit f642ee4
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions doc/man3/X509_dup.pod
Original file line number Diff line number Diff line change
Expand Up @@ -360,13 +360,12 @@ binary data using B<d2i_I<TYPE>>().

B<I<TYPE>_dup>() copies an existing object, leaving it untouched.
Note, however, that the internal representation of the object
may contain extra data besides the ASN.1 structure.
For instance, an B<X509> object usually is augmented
by cached information on X.509v3 extensions, etc.
Such extra data is not copied.
If it needs to be retained, it may be better to use B<I<TYPE>_up_ref>().
may contain besides the ASN.1 structure further data, which is not copied.
For instance, an B<X509> object usually is augmented by cached information
on X.509v3 extensions, etc., and losing it can lead to wrong validation results.
To avoid such situations, better use B<I<TYPE>_up_ref>() if available.
For the case of B<X509> objects, an alternative to using L<X509_up_ref(3)>
is to still call B<I<TYPE>_dup>(), e.g., I<copied_cert = X509_dup(cert)>,
may be to still call B<I<TYPE>_dup>(), e.g., I<copied_cert = X509_dup(cert)>,
followed by I<X509_check_purpose(copied_cert, -1, 0)>,
which re-builds the cached data.

Expand Down

0 comments on commit f642ee4

Please sign in to comment.