-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: instant job event notifications #24
Merged
stormc
merged 1 commit into
siemens:main
from
michaeladler:11-notify-clients-on-job-updates
Dec 13, 2023
Merged
feat: instant job event notifications #24
stormc
merged 1 commit into
siemens:main
from
michaeladler:11-notify-clients-on-job-updates
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 79.82% 79.85% +0.03%
==========================================
Files 80 85 +5
Lines 3033 3376 +343
==========================================
+ Hits 2421 2696 +275
- Misses 443 492 +49
- Partials 169 188 +19 ☔ View full report in Codecov by Sentry. |
2a40208
to
e8caa57
Compare
e8caa57
to
11498fb
Compare
11498fb
to
d15fa3a
Compare
18c9db7
to
f7780c1
Compare
a3abf39
to
e21e837
Compare
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
stormc
reviewed
Oct 19, 2023
e59e165
to
fbc1288
Compare
ca6f043
to
dea3000
Compare
dea3000
to
df60c30
Compare
49e1945
to
5e83b40
Compare
5e83b40
to
51aefc6
Compare
stormc
reviewed
Dec 13, 2023
51aefc6
to
3580cda
Compare
stormc
reviewed
Dec 13, 2023
This commit introduces a more efficient mechanism for notifications related to job events, such as creation, updating, and deletion. Unlike the previous architecture, where clients had to constantly poll the server for updates, the new implementation uses server-sent events (SSE) to allow clients to receive updates from the server, improving efficiency and reducing network overhead. Key Features: - Introduced a new SSE-enabled endpoint, `/jobs/events`, which accepts filter parameters to customize the stream of events received. - Clients can subscribe to `/jobs/events` to receive updates on job events that meet specified filter criteria. - Provided a client reference implementation through `wfxctl`. Signed-off-by: Michael Adler <[email protected]>
9a20072
to
7ae90b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces a more efficient mechanism for notifications
related to job events, such as creation, updating, and deletion. Unlike
the previous architecture where clients had to constantly poll the
server for updates, the new implementation uses server-sent events (SSE)
to allow client to receive updates from the server , improving
efficiency and reducing network overhead.
Key Features:
/jobs/events
, which acceptsfilter parameters to customize the stream of events received.
/jobs/events
for to receive updates on jobevents that meet specified filter criteria.
wfxctl
.Issues Addressed
Closes #11
Change Type
Please select the relevant options:
Checklist