Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecations #37

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Conversation

michaeladler
Copy link
Member

@michaeladler michaeladler commented Aug 22, 2023

Description

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

ioutil is deprecated in Go 1.19

Signed-off-by: Michael Adler <[email protected]>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #37 (9dc0031) into main (ecf9563) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   77.66%   77.66%           
=======================================
  Files          79       79           
  Lines        3027     3027           
=======================================
  Hits         2351     2351           
  Misses        497      497           
  Partials      179      179           

This option is now default and can't be changed.

Signed-off-by: Michael Adler <[email protected]>
@michaeladler michaeladler changed the title refactor: stop using ioutil Fix deprecations Aug 23, 2023
According to the Go support policy, major releases are maintained until
two subsequent major versions are released. Although Go 1.19 has
technically reached its end-of-life, it's worth noting that Debian
Bookworm currently only ships Go 1.19. As wfx remains unaffected by
this version, we're retaining compatibility for the time being.

Signed-off-by: Michael Adler <[email protected]>
@stormc stormc merged commit 53a9b5f into siemens:main Aug 28, 2023
13 checks passed
@michaeladler michaeladler deleted the feat/remove-deprecations branch August 28, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants