Rename container div to #simple-translate-container #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #521.
I have a blog created using Astro on which I posted about Simple Translate. When Astro converts the Markdown header to HTML it automatically gives the h3 an ID matching the text of the header. In this case, that's
<h3 id="simple-translate">.This happens to conflict with the container div for Simple Translate and causes rendering issues on the page.
Admittedly, an ideal PR might do something like inlining the CSS styles on the proper elements or add a build step to randomize the IDs used for Simple Translate elements. Unfortunately, I'm not that clever so this PR simple renames the container to
simple-translate-containerwhich I expect is less likely to conflict in the wild.