Fix developer setup section for windows #5342
Conversation
Remove reference to https://github.com/felixrieseberg/windows-build-tools. According to the commits the project switched to Python 3, but it seems like there has not been a release since and the project seems to be unmaintained. Therefore it still installs Python 2.7. Added "Download Build Tools for Visual Studio" and "Download Python 3" as steps.
|
Not sure if it was this or installing a full installation of VS2015 that fixed my bug, but this is a great PR. At the very least, we need to make the instructions easier to follow for installation. I'm a senior dev and the current instructions are definitely missing steps. |
|
@scottnonnenberg-signal and @EvanHahn-Signal, I don't want to bother you too much, but is there any reason, this is not yet merged? Same goes for two other very small open PRs by me (#5961, #5960), they should be pretty much no work to review in my opinion and get marked as stale from time to time, which is kind of frustrating and not really motivating me for future contributions, if I'm being honest. |
|
We’ve merged this internally, and it will be released in our next beta family. Thanks! |
Contributor checklist:
developmentbranchyarn readyrun passes successfully (more about tests here)Description
This PR references a post (Building with vs2015 fails) on the community forum. While researching the issue i found multiple people having problems with https://github.com/felixrieseberg/windows-build-tools (e.g. felixrieseberg/windows-build-tools#252, felixrieseberg/windows-build-tools#251, felixrieseberg/windows-build-tools#172). According to the commits the project switched to Python 3, but it seems like there has not been a release since and the project seems to be unmaintained. The workaround mentioned in my community forum post (partially sourced from felixrieseberg/windows-build-tools#172) seems overly complicated and installing the two dependencies manually more reasonable to me.
Removes reference to https://github.com/felixrieseberg/windows-build-tools.
Added "Download Build Tools for Visual Studio" and "Download Python 3" as steps.
The PR might also fix/ would have prevented some of the issues that holahila is having on the community forum (I get an error when I run the command “yarn install –frozen-lockfile”), but I'm not sure.
The old setup instructions failed on multiple Windows 10 machines, I verified the new procedure on a fresh installation.