Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace recursive call with while loop to prevent stack overflow. #5884

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace recursive call with while loop to prevent stack overflow. #5884

wants to merge 1 commit into from
+4 −7

Conversation

VasilErema
Copy link

@VasilErema VasilErema commented Oct 1, 2024 •
edited
Loading

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • Simulator iPhone 16 PRO , iOS 18.0

Description

  • Recursive call might cause stack overflow if called to many times.
  • Improvement: replace recursive call with while loop, that won't be affected by the issue.

P.S. I had no stack overflow with old/new code when tested - there was no recursive calls. I picked it as a small first contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankushkushwaha ankushkushwaha ankushkushwaha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasilErema @ankushkushwaha