Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachment names from using the wrong year #5942

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarlowBrown
Copy link

@MarlowBrown MarlowBrown commented Jan 21, 2025

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 16, iOS 18.2

Description

This bug fixes #5932. This bug originated from using YYYY (Week of Year) instead of yyyy (The calendar year). According to Apple's documentation, both of them for the most part deliver the same result; however, there are certain occasions when it can produce different ones.

To test that my fix has worked I changed my system time to the reported time used in the bug report. I then performed the step for the bug and the bug did not happen anymore.

…he calendar year). According to apples documentation both of them for the most part deliver the same result, however there are certain occasions that it can produce different ones.

(cherry picked from commit bffba0bc97fa3cde53b4fb0dece2d50f4cd5e8af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant