Update CI to build for all matrix targets #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eager-signal
force-pushed
the
ci_matrix_targets
branch
from
135e452 to
39b5695
Compare
jrose-signal
force-pushed
the
ci_matrix_targets
branch
6 times, most recently
from
aee977f to
878ef68
Compare
eager-signal
force-pushed
the
ci_matrix_targets
branch
from
f3c58ae to
d2e1003
Compare
eager-signal
force-pushed
the
ci_matrix_targets
branch
17 times, most recently
from
7e4bb78 to
22e2d5b
Compare
eager-signal
force-pushed
the
ci_matrix_targets
branch
from
6be981c to
46433e3
Compare
We introduce new methods replace_ex_data for both SslContextBuilder and Ssl in case anyone is relying on the leaking behaviour of their set_ex_data methods, but we do document that they leak now.
Setting callbacks multiple times on a SslContextBuilder causes the previous callback installed to leak, using replace_ex_data internally prevents that. We also start using it in tokio-boring in with_ex_data_future, my understanding is that the futures currently in use are never installed twice by that function but that could change in the future with the addition of more async callbacks.
This helps drive async callbacks from outside tokio-boring, such as in quiche. Not a breaking change because every public item in tokio-boring is preserved as is.
(or macOS->macOS)
This is only necessary for the windows-gnu target, but causes no issues anywhere else.
x86_64-pc-windows-gnu is identified as `target_env = "msvc"` too, but doesn't use the Visual Studio CMake generator.
eager-signal
force-pushed
the
ci_matrix_targets
branch
from
46433e3 to
789b6a2
Compare
|
This branch was merged upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.