fix(session-replay): id increment #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joozty
commented
Nov 12, 2024
| const eventI = eventCounter | ||
| eventCounter += 1 |
Fix bug introduced by the eslint update in #879. Previously, the `++` operator was used, which increments the value after the variable is accessed. We switched to `+=` and moved it before the variable is used, causing issues with the indices.
Joozty
force-pushed
the
fix/increment
branch
from
79126e1
to
a4a4074
Compare
Joozty
commented
Nov 12, 2024
| @@ -4,7 +4,7 @@ This is a [Next.js](https://nextjs.org/) project bootstrapped using [`create-nex | |||
|
|
|||
| ## Instrumenting with Splunk RUM using NPM installation method | |||
|
|
|||
| Next.js uses [static generation](https://nextjs.org/docs/basic-features/pages#pre-rendering) by default to generate the output HTML for most pages. As static generation is done using the node.js runtime, it isn't compatible with RUM. Check that RUM is only imported and activated in the browser environment. | |||
There was a problem hiding this comment.
The link return 404 and link checker in CI fails. I decided to remove it. This example needs to remove anyway.
amertak
approved these changes
Nov 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug introduced by the eslint update in #879. Previously, the
++operator was used, which increments the value after the variable is accessed. We switched to+=and moved it before the variable is used, causing issues with the indices.Type of change
Delete options that are not relevant.
How has this been tested?
Delete options that are not relevant.