Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decode correct part of the cookie #962

Merged
merged 2 commits into from
Feb 26, 2025
Merged

fix: decode correct part of the cookie #962

merged 2 commits into from
Feb 26, 2025

Conversation

Joozty
Copy link
Member

@Joozty Joozty commented Feb 26, 2025

Description

Decodes the correct part of the cookie. Calling decodeURIComponent on the entire cookie value may fail if it contains unescaped characters stored by someone.

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Delete options that are not relevant.

  • Manual testing

@Joozty Joozty self-assigned this Feb 26, 2025
@Joozty Joozty requested a review from amertak February 26, 2025 09:21
@Joozty Joozty marked this pull request as ready for review February 26, 2025 09:21
@Joozty Joozty requested review from a team as code owners February 26, 2025 09:21
@Joozty Joozty merged commit 198f182 into main Feb 26, 2025
10 checks passed
@Joozty Joozty deleted the fix/cookie branch February 26, 2025 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants