Qbft justifications #122
Merged
Qbft justifications #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we know how to fix this failing CI? |
I investigated a bit, see #123 |
dknopik
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Added some first thoughts.
Update: There are a few bugs in this code that I have fixed in the qbft testing pr. Can also make the updates here if needed.
If it's not a lot of effort, it would be nice if you merge the fixes into this one.
There are a lot of TODOs in the comment, and one todo!() invocation. Do you plan to address them, and do you want to discuss any specific ones?
dknopik
reviewed
Feb 6, 2025
dknopik
reviewed
Feb 6, 2025
|
added #127 to track getting rid of some of these |
dknopik
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#106
Proposed Changes
This is an initial implementation of the round change and prepare justifications for proper qbft behavior. The actual justification implementation is pretty small, but a lot of message validation checks have been added in from the spec. In the future, we can more rigorously sift through the checks to only keep what we need.
Additional Info
We do not have the the infra in place to properly test this. I have a follow up PR in progress that adds testing functionality (#98). The plan is to get this in and then follow up with another PR where all testing, bugfixes, and general productionizing occur so that the scope of this PR is limited.
Update: There are a few bugs in this code that I have fixed in the qbft testing pr. Can also make the updates here if needed.