Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce self-hosted runners #4115

Closed
wants to merge 2 commits into from
Closed

Introduce self-hosted runners #4115

wants to merge 2 commits into from

Conversation

antondlr
Copy link
Member

Run the following CI tasks on self-hosted runners:

  • test-suite/release-tests-ubuntu
  • test-suite/release-tests-windows
  • test-suite/beacon-chain-tests
  • test-suite/ef-tests-ubuntu

Some tasks are no longer run inside the workflow ( installation of some dependencies, rustup update):

  • the runners come preinstalled with all necessary dependencies
  • the images are automatically rebuilt weekly, and the containers are respawned w. updated images after running any task

Currently there are 2 active runners of each flavour:
[windows-1, windows-2, large-1, large-2, small-1, small-2]

@antondlr
Copy link
Member Author

interesting failure there... I don't have sufficient permissions to manually trigger a re-run

@paulhauner
Copy link
Member

interesting failure there... I don't have sufficient permissions to manually trigger a re-run

Re-run triggered!

@paulhauner
Copy link
Member

I've blocked this on some internal devops changes we need to do (DM me for deets). I should be able to clear those this week 🤞

@paulhauner
Copy link
Member

Re-run triggered!

Same weird error 🤔

@antondlr
Copy link
Member Author

Re-run triggered!

Same weird error 🤔

oooops... I changed something during / right after submitting this PR, breaking ipv6 tests
it's fixed now!
(and of course when these runners are in-use I won't test changes on them but on clones.. so this shouldn't happen again)

@paulhauner
Copy link
Member

We're waiting on one more senior infosec engineer to get their eyes across this one. ETA one week 🙏

@jimmygchen jimmygchen mentioned this pull request Apr 20, 2023
Closed
@michaelsproul michaelsproul mentioned this pull request May 12, 2023
Closed
@realbigsean realbigsean mentioned this pull request Jun 30, 2023
Closed
@paulhauner
Copy link
Member

I've just resolved the merge conflicts. It was fairly straight-forward but I note two things:

  • We've moved from ganache to Anvil. Therefore Ganache can probably be removed from the builder images and Anvil can be added.
  • Since this PR was made we've moved from Windows LLVM v13 to v15.

If Windows builds start failing we might need to add this snippet to bump LLVM:

lighthouse/.github/workflows/test-suite.yml

Lines 86 to 89 in 0c7eed5

- uses: KyleMayes/install-llvm-action@v1
with:
version: "15.0"
directory: ${{ runner.temp }}/llvm

@paulhauner paulhauner mentioned this pull request Jul 14, 2023
Closed
@paulhauner
Copy link
Member

Closed in favour of #4506

@paulhauner paulhauner closed this Jul 21, 2023
bors bot pushed a commit that referenced this pull request Jul 21, 2023
@paulhauner @antondlr
Add self-hosted runners v2 (#4506)
071dd4c 
## Issue Addressed

NA

## Proposed Changes

Carries on from #4115, with the following modifications:

1. Self-hosted runners are only enabled if `github.repository == sigp/lighthouse`.
    - This allows forks to still have Github-hosted CI.
    - This gives us a method to switch back to Github-runners if we have extended downtime on self-hosted. 
1. Does not remove any existing dependency builds for Github-hosted runners (e.g., installing the latest Rust).
1. Adds the `WATCH_HOST` environment variable which defines where we expect to find the postgres db in the `watch` tests. This should be set to `host.docker.internal` for the tests to pass on self-hosted runners.

## Additional Info

NA


Co-authored-by: antondlr <[email protected]>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@paulhauner @antondlr @Woodpile37
Add self-hosted runners v2 (sigp#4506)
1e8bef8 
## Issue Addressed

NA

## Proposed Changes

Carries on from sigp#4115, with the following modifications:

1. Self-hosted runners are only enabled if `github.repository == sigp/lighthouse`.
    - This allows forks to still have Github-hosted CI.
    - This gives us a method to switch back to Github-runners if we have extended downtime on self-hosted. 
1. Does not remove any existing dependency builds for Github-hosted runners (e.g., installing the latest Rust).
1. Adds the `WATCH_HOST` environment variable which defines where we expect to find the postgres db in the `watch` tests. This should be set to `host.docker.internal` for the tests to pass on self-hosted runners.

## Additional Info

NA


Co-authored-by: antondlr <[email protected]>
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@paulhauner @antondlr @Woodpile37
Add self-hosted runners v2 (sigp#4506)
f8fef6e 
## Issue Addressed

NA

## Proposed Changes

Carries on from sigp#4115, with the following modifications:

1. Self-hosted runners are only enabled if `github.repository == sigp/lighthouse`.
    - This allows forks to still have Github-hosted CI.
    - This gives us a method to switch back to Github-runners if we have extended downtime on self-hosted. 
1. Does not remove any existing dependency builds for Github-hosted runners (e.g., installing the latest Rust).
1. Adds the `WATCH_HOST` environment variable which defines where we expect to find the postgres db in the `watch` tests. This should be set to `host.docker.internal` for the tests to pass on self-hosted runners.

## Additional Info

NA


Co-authored-by: antondlr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antondlr @paulhauner