[Merged by Bors] - Enable slasher broadcast by default #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I based on @michaelsproul lmdb-default branch. Hence, this is showing those changes too. #4360 |
…a/lighthouse into default-slasher-broadcast
|
This should work now as anvil as been fixed as of #4381 |
|
@Gua00va looks like there's a small merge conflict, would you mind resolving it by merging in |
I have resolved the merge conflict. |
michaelsproul
added
ready-for-review
michaelsproul
changed the title
michaelsproul
added
ready-for-merge
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
## Issue Addressed This PR addresses issue #4350 ## Proposed Changes This change will enable slasher broadcast in the following cases: No flag is passed, `--slasher-broadcast` is passed and, `--slasher-broadcast=true` is passed. Only when an explicit false value is passed the slasher does not broadcast.(`--slasher-broadcast=false`). ## Additional Info TODO - [x] Modify CLI parsing logic - [x] Write test Refer to #4353 Co-authored-by: Rahul Dogra <[email protected]> Co-authored-by: Gua00va <[email protected]>
|
Build failed: |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
## Issue Addressed This PR addresses issue #4350 ## Proposed Changes This change will enable slasher broadcast in the following cases: No flag is passed, `--slasher-broadcast` is passed and, `--slasher-broadcast=true` is passed. Only when an explicit false value is passed the slasher does not broadcast.(`--slasher-broadcast=false`). ## Additional Info TODO - [x] Modify CLI parsing logic - [x] Write test Refer to #4353 Co-authored-by: Rahul Dogra <[email protected]> Co-authored-by: Gua00va <[email protected]>
|
Timed out. |
|
bors retry 🙏 |
bors bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
## Issue Addressed This PR addresses issue #4350 ## Proposed Changes This change will enable slasher broadcast in the following cases: No flag is passed, `--slasher-broadcast` is passed and, `--slasher-broadcast=true` is passed. Only when an explicit false value is passed the slasher does not broadcast.(`--slasher-broadcast=false`). ## Additional Info TODO - [x] Modify CLI parsing logic - [x] Write test Refer to #4353 Co-authored-by: Rahul Dogra <[email protected]> Co-authored-by: Gua00va <[email protected]>
|
Pull request successfully merged into unstable. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
bors
bot
changed the title
ghost
pushed a commit
to oone-world/lighthouse
that referenced
this pull request
Jul 13, 2023
## Issue Addressed This PR addresses issue sigp#4350 ## Proposed Changes This change will enable slasher broadcast in the following cases: No flag is passed, `--slasher-broadcast` is passed and, `--slasher-broadcast=true` is passed. Only when an explicit false value is passed the slasher does not broadcast.(`--slasher-broadcast=false`). ## Additional Info TODO - [x] Modify CLI parsing logic - [x] Write test Refer to sigp#4353 Co-authored-by: Rahul Dogra <[email protected]> Co-authored-by: Gua00va <[email protected]>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed This PR addresses issue sigp#4350 ## Proposed Changes This change will enable slasher broadcast in the following cases: No flag is passed, `--slasher-broadcast` is passed and, `--slasher-broadcast=true` is passed. Only when an explicit false value is passed the slasher does not broadcast.(`--slasher-broadcast=false`). ## Additional Info TODO - [x] Modify CLI parsing logic - [x] Write test Refer to sigp#4353 Co-authored-by: Rahul Dogra <[email protected]> Co-authored-by: Gua00va <[email protected]>
Woodpile37
pushed a commit
to Woodpile37/lighthouse
that referenced
this pull request
Jan 6, 2024
## Issue Addressed This PR addresses issue sigp#4350 ## Proposed Changes This change will enable slasher broadcast in the following cases: No flag is passed, `--slasher-broadcast` is passed and, `--slasher-broadcast=true` is passed. Only when an explicit false value is passed the slasher does not broadcast.(`--slasher-broadcast=false`). ## Additional Info TODO - [x] Modify CLI parsing logic - [x] Write test Refer to sigp#4353 Co-authored-by: Rahul Dogra <[email protected]> Co-authored-by: Gua00va <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This PR addresses issue #4350
Proposed Changes
This change will enable slasher broadcast in the following cases:
No flag is passed,
--slasher-broadcastis passed and,--slasher-broadcast=trueis passed.Only when an explicit false value is passed the slasher does not broadcast.(
--slasher-broadcast=false).Additional Info
TODO
Refer to #4353