-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Add self-hosted runners v2 #4506
Closed
Closed
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
6e639fe
run bigger tasks on self hosted runners
antondlr 769b130
Merge branch 'unstable' into self-hosted-runners
paulhauner da921b0
Revert dependency installation
paulhauner 2eb7457
Add libpq-dev
paulhauner 42ca4c8
Empty commit
paulhauner 9a4c459
Run debug tests on self-hosted runners
paulhauner d369c18
Remove Rust update for self-hosted tasks
paulhauner eba6dd3
Revert to Github runner for Windows tests
paulhauner 9e5e0f2
Add runners as variables
paulhauner 8bc4e99
Remove sudo when installing libpq-dev
paulhauner 3472e60
Run rustup update when not using self-hosted
paulhauner e705411
Use repository-level environment variable
paulhauner 853d447
Remove bangs
paulhauner d85891e
Use `== 'true'` in ternary operator
paulhauner bc883e6
Add temporary debug stuff
paulhauner a90df60
Add another debug line
paulhauner 7148b13
Modify debug statements
paulhauner 04deb0f
More debugging
paulhauner 5880179
Start using `github.repository`
paulhauner 4749645
Try using toJson
paulhauner 1cd9e9d
Revert "Try using toJson"
paulhauner 74542b7
Test with just string for `runs-on`
paulhauner c3625d3
Try fromJson
paulhauner 7db66c7
Implement fromJson globally
paulhauner e008422
Switch windows to self-hosted
paulhauner b62e79a
Swap vars to env
paulhauner c7862f9
Fix ef-tests
paulhauner d92bf62
Use sudo for self-hosted runners
paulhauner a0619ac
Add 7zip to windows runner
paulhauner b57c114
Install `7zip` rather than `7zip.install`
paulhauner c9476bd
Disable LLVM update for Windows runner
paulhauner 7f45652
Merge branch 'unstable' into self-hosted-runners-paul
paulhauner 2f9243f
Change watch DB host
paulhauner 0adaf83
Add watch host for debug tests too
paulhauner 21be30c
Fix compile error
paulhauner acb9c29
Remove libpq install
paulhauner ce4ed6e
Allow `WATCH_HOST` to be `localhost` on Github runners
paulhauner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good with this but just something worth thinking - Is there any benefit of leaving these conditionals out?
There are a few benefits:
Downside:
rustup update stable
just returns immediately if we're already on the same version.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC the self-hosted runners fail if we run that llvm install action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with the Rust update ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh privileges! happy to leave it as it is 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would be ideal if we can have the images perform exactly the same. Perhaps we can make an issue to come back for it.
I suspect that we're going to eventually drift into the territory of Github-hosted runners failing, though. If we're not actually testing on the Github-hosted ones they're bound to bit-rot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's a good point - I'm hesitant to make the workflow more complicated, but if we really want to run GitHub-hosted runners, we could still run them on PRs, and use the self-hosted ones on
staging
😛 , but perhaps something to think about later down the line.