Fix issue where prune blobs can OOM #6571
Open
+1,517
−603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dularize-beacon-node-backend
…serilev/lighthouse into modularize-beacon-node-backend
…serilev/lighthouse into modularize-beacon-node-backend
…dularize-beacon-node-backend
…dularize-beacon-node-backend
…dularize-beacon-node-backend
…dularize-beacon-node-backend
…x-prune-blobs-oom-bug
eserilev
added
blocked
optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#6559
Proposed Changes
Add a
delete_whiledb method that iterates through records in the db and removes all records where provided predicate evaluates to false. Use this new method in the blobstry_prunemethodTODO
remove BlobInfo as it can be totally deprecated. Now we now longer need to worry about atomic transactions across two separate dbs
Blocked by #4718