Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web3signer test fails on macOS #6588

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Fix web3signer test fails on macOS #6588

wants to merge 4 commits into from
+210 −193

Conversation

ackintosh
Copy link
Member

Issue Addressed

#6442

Proposed Changes

Additional Info

The validity period of certificates has changed to 825 days, so it's worth considering how to update the certificates automatically:

  • Create a GitHub Actions job to update the certificates periodically, for example, every year.
  • Generate the certificates for each test run.

@ackintosh ackintosh marked this pull request as ready for review November 17, 2024 06:26
@ackintosh ackintosh added the ready-for-review The code is ready for review label Nov 17, 2024
dapplion
dapplion approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@ackintosh ackintosh added the test improvement Improve tests label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
ready-for-review The code is ready for review test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ackintosh @dapplion