Make ValidatorIndex visible
#6621
Open
+752
−434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jxs
reviewed
Nov 29, 2024
| @@ -1,7 +1,7 @@ | |||
| use crate::*; | |||
| use rpds::HashTrieMapSync as HashTrieMap; | |||
|
|
|||
| type ValidatorIndex = usize; | |||
| pub type ValidatorIndex = usize; | |||
There was a problem hiding this comment.
this is a type alias, if consensus is exposing a function/method that requires ValidatorIndex we should probably either switch it to usize or make ValidatorIndex a newtype to avoid breaking change issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
Change
ValidatorIndexto pub and export itAdditional Info
Needed for defining types in Anchor