Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codeowners, to be more specific #7021

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

jxs
Copy link
Member

@jxs jxs commented Feb 21, 2025

Issue Addressed

I keep being notified for PR's like #7009 where it doesn't touch the specified directories in the CODEOWNERS file.
After reading the docs not having a forward slash in beginning of the path means:

In this example, @octocat owns any file in an apps directory
anywhere in your repository.

whereas with the slashes:

In this example, @doctocat owns any file in the /docs
directory in the root of your repository and any of its
subdirectories.

this update makes it more rigid for the files in the jxs ownership

@michaelsproul
Copy link
Member

I think the reason you were notified for 7009 is that we changed the target branch, which brought in everything from unstable to the PR, and then we rebased so the commits from unstable were no longer part of the PR

It might be better if we rebase first and then change the target branch, but github actions has a quirk where it won't re-trigger the target branch check when the target changes, meaning another rebase/dummy commit is required to get it to update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants