Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update sigstore/sigstore-conformance action to v0.0.8 - autoclosed #550

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 23, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
sigstore/sigstore-conformance action patch v0.0.6 -> v0.0.8

Release Notes

sigstore/sigstore-conformance (sigstore/sigstore-conformance)

v0.0.8

Compare Source

What's Changed

Full Changelog: sigstore/sigstore-conformance@v0.0.7...v0.0.8

v0.0.7

Compare Source

What's Changed

New Contributors

Full Changelog: sigstore/sigstore-conformance@v0.0.6...v0.0.7


Configuration

📅 Schedule: Branch creation - "every 3 weeks on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@jku
Copy link
Member

jku commented Oct 23, 2023

Five failing tests but I think only two separate issues:

  1. sign-bundle not supported?
    test.client.ClientFail, test_verify_empty[BundleMaterials], test_verify_mismatch[BundleMaterials], test_simple[BundleMaterials]: all of these fail with

    E           Unmatched arguments from index 0: 'sign-bundle', '--identity-token', '***', '--bundle', 'a.txt.sigstore', 'a.txt'
    E           Did you mean: sigstore verify-bundle?
    
  2. Invalid inclusion proof seems to accepted?

    test_verify_rejects_invalid_inclusion_proof expects a failure but succeeds:

    E           test.client.ClientUnexpectedSuccess: 
    E           Command: /home/runner/work/sigstore-java/sigstore-java/bin/sigstore-cli verify-bundle --bundle a.txt.invalid_inclusion_proof.sigstore --certificate-identity https://github.com/sigstore-conformance/extremely-dangerous-public-oidc-beacon/.github/workflows/extremely-dangerous-oidc-beacon.yml@refs/heads/main --certificate-oidc-issuer https://token.actions.githubusercontent.com/ a.txt
    E           Exit code: 0
    E           
    E           !!! STDOUT !!!
    E           ==============
    E           
    E           
    E           
    E           !!! STDERR !!!
    E           ==============
    E           
    E           None
    

@loosebazooka
Copy link
Member

Yeah I think it has to do with "online verification", we don't double check the provided inclusion proof if we have already verified it online. But we probably need to do both (like we do for SET) or change our "online" handling a bit.

@renovate renovate bot changed the title chore(deps): update sigstore/sigstore-conformance action to v0.0.8 chore(deps): update sigstore/sigstore-conformance action to v0.0.8 - autoclosed Oct 26, 2023
@renovate renovate bot closed this Oct 26, 2023
@renovate renovate bot deleted the renovate/sigstore-sigstore-conformance-0.x branch October 26, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants