Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove "Signing publications" from the logging output #603

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

vlsi
Copy link
Collaborator

@vlsi vlsi commented Jan 9, 2024

Summary

The message was not adding much, and it was emitted during configuration phase, so it was not even aligned with the actual signing work.

Release Note

NONE

Documentation

NONE

@loosebazooka
Copy link
Member

gotta dco it

@vlsi
Copy link
Collaborator Author

vlsi commented Jan 9, 2024

Frankly, DCO is useless since GitHub's terms of service already require that any content someone posts on GitHub must comply with the target's license: https://docs.github.com/en/site-policy/github-terms/github-terms-of-service#6-contributions-under-repository-license

See https://ben.balter.com/2018/01/02/why-you-probably-shouldnt-add-a-cla-to-your-open-source-project/#if-a-license-isnt-good-enough-for-maintainers-you-shouldnt-subject-users-to-it

Can we somehow lift DCO restriction?
I'm running into this DCO validation every time, and it does take time to re-commit and re-push

The message was not adding much, and it was emitted during configuration phase,
so it was not even aligned with the actual signing work.

Signed-off-by: Vladimir Sitnikov <[email protected]>
@loosebazooka
Copy link
Member

Yeah, it's just applied across all sigstore repos. So I dunno 🤷

@loosebazooka loosebazooka merged commit b1d5e99 into sigstore:main Jan 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants