Add checkpoint verification #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Appu Goundan <[email protected]>
bobcallaway
reviewed
Mar 26, 2024
| var keyHash = Hashing.sha256().hashBytes(tlog.getPublicKey().getRawBytes()).asBytes(); | ||
| // checkpoint 0 is always the log, not any of the cross signing verifiers/monitors | ||
| var sig = checkpoint.getSignatures().get(0); | ||
| for (int i = 0; i < 4; i++) { |
There was a problem hiding this comment.
Key ID is 4 bytes, https://github.com/sigstore/rekor/blob/main/pkg/util/signed_note.go#L140, truncated public key hash
There was a problem hiding this comment.
Would be good to have a link to that or https://github.com/C2SP/C2SP/blob/main/signed-note.md#signatures
There was a problem hiding this comment.
that should be added in a comment at least IMO
There was a problem hiding this comment.
It's defined in the spec and the spec is linked in the checkpoint type
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
negative test cases are here: sigstore/sigstore-conformance#139
it's always a bit weird to mirror those test cases in sigstore-java, but I guess I can?