Generate java client for proto at build #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
protobuf-spec-gen-at-client
branch
from
5ecc9ed to
119dcf9
Compare
haydentherapper
previously approved these changes
Apr 5, 2024
loosebazooka
force-pushed
the
protobuf-spec-gen-at-client
branch
6 times, most recently
from
38b27b2 to
9e3ed29
Compare
Stop using pre-generated protobuf client libraries, just use the proto files directly when generating clients. This allows us to update proto-gen versions without worrying about conflicts. Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
protobuf-spec-gen-at-client
branch
from
9e3ed29 to
c3b2160
Compare
|
I think fuzzing instrumentation is broken on protobuf 4, we'll just have to leave it broken while we figure it out. This PR should still go in though. |
haydentherapper
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using pre-generated protobuf client libraries, just use the proto files directly when generating clients. This allows us to update proto-gen versions without worrying about conflicts (We were geneating client for fulcio.proto locally while using pre generated proto clients for protobuf-spec)
A followup to this will be to remove the generator from https://github.com/sigstore/protobuf-specs and only publish the .proto files in a jar.
Also supersedes #669