Use new oci compat mediatype for bundles #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
protobuf-spec-oci-mediatype
branch
from
c2d8b52 to
e507ccc
Compare
haydentherapper
previously approved these changes
May 2, 2024
| @@ -59,8 +59,10 @@ class BundleFactoryInternal { | |||
| private static final String BUNDLE_V_0_1 = "application/vnd.dev.sigstore.bundle+json;version=0.1"; | |||
| private static final String BUNDLE_V_0_2 = "application/vnd.dev.sigstore.bundle+json;version=0.2"; | |||
| private static final String BUNDLE_V_0_3 = "application/vnd.dev.sigstore.bundle+json;version=0.3"; | |||
| // media_type format switch: https://github.com/sigstore/protobuf-specs/pull/279 | |||
| private static final String BUNDLE_V_0_3_1 = "application/vnd.dev.sigstore.bundle.v0.3+json"; | |||
There was a problem hiding this comment.
To confirm, is there anywhere in the verification path where you need to treat BUNDLE_V_0_3_1 and BUNDLE_V_0_3 as equivalent bundles?
There was a problem hiding this comment.
equivalent? We just parse them or we dont.
There was a problem hiding this comment.
The reality of this is we only have a single parser based on the protobuf spec build at v0.3.1, we're pretty permissive with the bundle mediatype. We don't punish v2, v1 bundles that use v3 features. If the v3 parser can parse it, we're okay and we use it.
There was a problem hiding this comment.
In fact, we ignore that v1 allows no inclusion proof. Those bundles are invalid as far as we're concerned.
Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
protobuf-spec-oci-mediatype
branch
from
e507ccc to
7649d8e
Compare
haydentherapper
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.