Allow cli to run with alt tuf remote repository #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
custom-tuf-in-cli
branch
from
e41df29 to
2e57381
Compare
loosebazooka
commented
May 28, 2024
Comment on lines
+58
to
+69
| @Option( | ||
| names = {"--public-good-with-tuf-url-override"}, | ||
| description = "use public good with a tuf remote repository override", | ||
| required = false) | ||
| String publicGoodWithTufUrlOverride; | ||
|
|
||
| @Option( | ||
| names = {"--staging-with-tuf-url-override"}, | ||
| description = "use staging with a tuf remote repository override", | ||
| required = false) | ||
| String stagingWithTufUrlOverride; | ||
| } |
There was a problem hiding this comment.
@jku there are the flags that allow changing the tuf url
jku
approved these changes
May 29, 2024
There was a problem hiding this comment.
👍 if you're ok putting this in the conformance cli, it does look like it allows me to easily include sigstore-java in the root-signing test workflow...
(I'm not promising that root-signing tests will include "all" clients forever, but it would be nice to have for the near to mid-term...)
|
yeah the cli is whatever we want it to be. Just an interface into core functionality. We never release it. |
vlsi
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jku presumably this should allow better conformance for the tuf repo. It does have separate flags for prod and staging (which allows the cli to be more robust), but it's not impossible to just use a single flag.