Integrate sigstore/sigstore-maven-plugin into repo #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vlsi there are some things with the gradle build logic I may not be completely following -- hoping you might have an idea if it looks okay. |
vlsi
reviewed
Jun 27, 2024
vlsi
reviewed
Jun 27, 2024
build-logic/publishing/src/main/kotlin/build-logic.java-published-library.gradle.kts
Outdated
Show resolved
Hide resolved
vlsi
reviewed
Jun 27, 2024
build-logic/publishing/src/main/kotlin/build-logic.publish-to-tmp-maven-repo.gradle.kts
Outdated
Show resolved
Hide resolved
loosebazooka
force-pushed
the
combine-maven
branch
2 times, most recently
from
64a5d9e to
61d91a9
Compare
loosebazooka
force-pushed
the
combine-maven
branch
from
61d91a9 to
db9f33f
Compare
patflynn
approved these changes
Jul 12, 2024
- Move sigstore-maven-plugin in sigstore/sigstore-java - Make it a gradle module (and build with gradle :o! sorry) Signed-off-by: Appu Goundan <[email protected]>
loosebazooka
force-pushed
the
combine-maven
branch
from
db9f33f to
38de185
Compare
|
@vlsi I'm going to get this moving along, feel free to keep commenting if you see anything. I'll make changes post-merge. |
patflynn
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: