Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sentry logging details #299

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Fix Sentry logging details #299

merged 7 commits into from
Dec 11, 2024

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Dec 11, 2024

IDP-779 Sentry log events are sometimes "unlabeled"

Added

  • Added the idp name to Sentry issues as a tag. This is searchable, sortable, and more visible than a context entry.

Fixed

  • Log a useful message to Sentry in cases where no explicit "message" key is included
  • Fixed error instances that had neither "message" nor "error"
  • Fixed "composershow" make target to generate valid json
  • Replace "G Suite" with "Google Workspace"

Changed

  • Don't report status 400 errors

PR Checklist

  • Documentation (README, local.env.dist, api.raml, etc.)
  • Tests created or updated
  • Run make composershow
  • Run make psr2

@briskt briskt requested review from a team as code owners December 11, 2024 09:29
@briskt briskt requested review from forevermatt, mtompset, jason-jackson and hobbitronics and removed request for a team December 11, 2024 09:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@briskt briskt merged commit 951dd0e into main Dec 11, 2024
4 checks passed
@briskt briskt deleted the sentry branch December 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Praveenraj-K Praveenraj-K Praveenraj-K approved these changes

@forevermatt forevermatt Awaiting requested review from forevermatt forevermatt is a code owner automatically assigned from silinternational/php-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

@hobbitronics hobbitronics Awaiting requested review from hobbitronics hobbitronics is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@briskt @Praveenraj-K