Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have IDP 4 use the next consecutive port number (8088) after IDP 3 #319

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Have IDP 4 use the next consecutive port number (8088) after IDP 3 #319

merged 2 commits into from
Mar 12, 2025

Conversation

forevermatt
Copy link
Contributor

Fixed

  • Switch local brokerpma container off of port 8088
  • Have IDP 4 use the next consecutive port number (8088) after IDP 3

@forevermatt
Switch local brokerpma container off of port 8088
a41085d 
This frees it up for use by ssp-idp4.local, to keep the IDP containers'
ports consecutive.
@forevermatt
Have IDP 4 use the next consecutive port number (8088) after IDP 3
b459345
@forevermatt forevermatt requested a review from briskt March 11, 2025 14:48
@forevermatt forevermatt requested a review from a team as a code owner March 11, 2025 14:48
@forevermatt forevermatt requested review from mtompset, ethancanne and jason-jackson and removed request for a team March 11, 2025 14:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@forevermatt forevermatt mentioned this pull request Mar 11, 2025
Merged
mtompset
mtompset approved these changes Mar 11, 2025
View reviewed changes
Copy link

@mtompset mtompset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't go looking for if there were any places you missed.

briskt
briskt approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@briskt briskt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@forevermatt forevermatt merged commit 4c4d6e9 into main Mar 12, 2025
3 checks passed
@forevermatt forevermatt deleted the feature/IDP-1424d-switch-idp4-port-number branch March 12, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briskt briskt briskt approved these changes

@mtompset mtompset mtompset approved these changes

@ethancanne ethancanne Awaiting requested review from ethancanne ethancanne is a code owner automatically assigned from silinternational/php-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/php-devs

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forevermatt @briskt @mtompset