-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for setting proxy #132
base: master
Are you sure you want to change the base?
Conversation
Hello @netanelgilad 😀 Please too add support for proxy basic authentication. ref: https://github.com/kevinsawicki/http-request#configuring-an-http-proxy |
12e8d19
to
a4f1217
Compare
Hi Netanel, I know this was a long time ago 😥... but I'm trying to keep Android and iOS features in sync. That's the reason I've not merged this PR. Would you mind implementing it also for iOS and writing some unit tests / e2e specs? Otherwise I'll close this PR because it seems not to be requested by many users. |
This would be a nice feature to have. I'm currently working with your library in a project and having to configure proxy to use the network. For now, the only way to do that is using an external app proxing all the network traffic in the device to our corporative proxy. But with some customers, it wouldn't be a viable solution. We are studying the possibilite to use @netanelgilad 's fork in our app to be able to set the proxy dynamically. So, if someone has the knowledge to implement the same feature for IOS, then, you can accept the PR, this feature will be a great improvement for your library! Thanks for now! |
Out of personal interest and since we have to develop behind a corporate firewall as well 👎 : Which app are you using that automatically redirects all network traffic through the proxy? |
We are currently using SandroProxy (Formerly Known as Drony) |
e8a8d65
to
0ccf64e
Compare
1a1c9e0
to
ed08534
Compare
449aa28
to
6fc8a7e
Compare
This PR adds the ability to set a proxy host and port. Setting a proxy was already available on HttpRequest, so I only added a method to expose it on the plugin interface.
Cheers 🍻