Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for setting proxy #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

netanelgilad
Copy link

This PR adds the ability to set a proxy host and port. Setting a proxy was already available on HttpRequest, so I only added a method to expose it on the plugin interface.

Cheers 🍻

@MarcosxDeveloper
Copy link

Hello @netanelgilad 😀

Please too add support for proxy basic authentication.

ref: https://github.com/kevinsawicki/http-request#configuring-an-http-proxy

@silkimen
Copy link
Owner

Hi Netanel, I know this was a long time ago 😥... but I'm trying to keep Android and iOS features in sync. That's the reason I've not merged this PR. Would you mind implementing it also for iOS and writing some unit tests / e2e specs? Otherwise I'll close this PR because it seems not to be requested by many users.

@MaikeMota
Copy link

This would be a nice feature to have. I'm currently working with your library in a project and having to configure proxy to use the network. For now, the only way to do that is using an external app proxing all the network traffic in the device to our corporative proxy. But with some customers, it wouldn't be a viable solution.

We are studying the possibilite to use @netanelgilad 's fork in our app to be able to set the proxy dynamically.

So, if someone has the knowledge to implement the same feature for IOS, then, you can accept the PR, this feature will be a great improvement for your library!

Thanks for now!

@jachstet-sea
Copy link

For now, the only way to do that is using an external app proxing all the network traffic in the device to our corporative proxy. But with some customers, it wouldn't be a viable solution.

Out of personal interest and since we have to develop behind a corporate firewall as well 👎 : Which app are you using that automatically redirects all network traffic through the proxy?

@MaikeMota
Copy link

We are currently using SandroProxy (Formerly Known as Drony)

@silkimen silkimen force-pushed the master branch 3 times, most recently from e8a8d65 to 0ccf64e Compare July 22, 2021 13:40
@silkimen silkimen force-pushed the master branch 8 times, most recently from 1a1c9e0 to ed08534 Compare March 30, 2022 14:19
@silkimen silkimen force-pushed the master branch 7 times, most recently from 449aa28 to 6fc8a7e Compare December 29, 2022 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants