Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct errors in the CI.yml #11

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Correct errors in the CI.yml #11

merged 2 commits into from
Mar 21, 2024

Conversation

jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Feb 8, 2024

This change is Reviewable

@jasonleenaylor jasonleenaylor force-pushed the feature/ci-gha branch 3 times, most recently from c375164 to 200a44d Compare March 6, 2024 23:53
jasonleenaylor and others added 2 commits March 21, 2024 11:00
- They should still run on properly setup developer systems
  and these tests have not caught regressions in over a decade

Change-Id: I762bdc34162b039cdc5af0b41a40d832d62238fb
Change-Id: I71e23e2562607cfc011bb8f184521610aa81223b
Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)

Copy link
Contributor Author

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)

Copy link
Contributor

@mark-sil mark-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)

@jasonleenaylor jasonleenaylor merged commit 23a9c52 into develop Mar 21, 2024
3 checks passed
@jasonleenaylor jasonleenaylor deleted the feature/ci-gha branch March 21, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants