LT-21706: Modify webonary status reporting

[jasonleenaylor]

---

This change is 

[JakeOliver28]

Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)

---

Src/xWorks/UploadToWebonaryController.cs line 157 at r1 (raw file):

		{
			// if the file is an image file, check for a license file
			if (file.EndsWith(".jpg", StringComparison.InvariantCultureIgnoreCase) ||

Could we consolidate this?

Code snippet:

var imageExtensions = new HashSet<string>(StringComparer.InvariantCultureIgnoreCase)
{
	".jpg", ".jpeg", ".gif", ".png"
};

if (imageExtensions.Contains(Path.GetExtension(file))
{
	
}

[jasonleenaylor]

Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @JakeOliver28)

---

Src/xWorks/UploadToWebonaryController.cs line 157 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…

Could we consolidate this?

Done.

[hahn-kev]

why the call Enum.ToObject instead of just casting the result of Math.Max directly to the enum? I can't see any functional difference

[JakeOliver28]

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @hahn-kev and @jasonleenaylor)

---

Src/xWorks/WebonaryLogViewer.cs line 60 at r1 (raw file):

			{
				// Read and deserialize JSON from file
				foreach (var line in File.ReadLines(filePath))

Should we remove the if statement from inside the loop?

Code snippet:

var nonEmptyLines = File.ReadLines(filePath)
                         .Where(line => !string.IsNullOrWhiteSpace(line));

foreach (var line in nonEmptyLines)
{
    try
    {
        var entry = JsonConvert.DeserializeObject<UploadLogEntry>(line);
        _logEntries.Add(entry);
    }
    catch (JsonException ex)
    {
        Console.WriteLine($"Error deserializing line: {ex.Message}");
    }
}

[jasonleenaylor]

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @hahn-kev and @JakeOliver28)

---

Src/xWorks/UploadToWebonaryDlg.cs line 331 at r2 (raw file):

Previously, hahn-kev (Kevin Hahn) wrote…

why the call Enum.ToObject instead of just casting the result of Math.Max directly to the enum? I can't see any functional difference

No good reason apparently.

---

Src/xWorks/WebonaryLogViewer.cs line 60 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…

Should we remove the if statement from inside the loop?

Done.

[JakeOliver28]

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @hahn-kev and @JakeOliver28)

Src/xWorks/UploadToWebonaryDlg.cs line 331 at r2 (raw file):

Previously, hahn-kev (Kevin Hahn) wrote…
No good reason apparently.

Src/xWorks/WebonaryLogViewer.cs line 60 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…
Done.

Were this change and the other change committed?

[jasonleenaylor]

Src/xWorks/WebonaryLogViewer.cs line 60 at r1 (raw file):

Previously, JakeOliver28 (Jake Oliver) wrote…

Were this change and the other change committed?

Hmm, apparently not. They are now! 👍

[JakeOliver28]

Reviewable status: 0 of 13 files reviewed, 3 unresolved discussions (waiting on @hahn-kev)