Skip to content

NFC-normalize entries loaded into spell-checker #3740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Apr 22, 2025

Fixes #3737

(Perhaps the next time the dictionaries are updated, a la #3717, the entries should be saved to file in NFC rather than NFD. However, that will require a change to scripts/split_dictionary.py since NFD is important for the file-splitting, so multiple normalizations will be employed.)


This change is Reviewable

@imnasnainaec imnasnainaec requested a review from andracc April 22, 2025 19:18
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.18%. Comparing base (9b07777) to head (d7f1bcb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3740   +/-   ##
=======================================
  Coverage   73.18%   73.18%           
=======================================
  Files         285      285           
  Lines       10673    10673           
  Branches     1332     1332           
=======================================
  Hits         7811     7811           
  Misses       2467     2467           
  Partials      395      395           
Flag Coverage Δ
backend 82.46% <ø> (ø)
frontend 65.91% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 6ed1ef7 into master Apr 23, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the spell-check-nfc branch April 23, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spellcheck] Our dictionary loader removes accented letters
2 participants