Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF-3211 Show source panel in editor if project has source selected #3051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylebuss
Copy link
Collaborator

@kylebuss kylebuss commented Feb 28, 2025

This PR addresses the source panel not being displayed at times. If the project has a selected source and the user is a Paratext user we want to always display the source side panel (except on small screens where the source and target are both tabs). Cases where the source panel would automatically hide were if there was a permissions issue for the user on the source or no book found in the source. We now keep the source panel open and display a message to the user.


This change is Reviewable

@kylebuss kylebuss added the will require testing PR should not be merged until testers confirm testing is complete label Feb 28, 2025
@kylebuss kylebuss force-pushed the improvement/sf-3211-always-show-source-editor branch from a491e6d to 2766889 Compare February 28, 2025 21:17
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.66%. Comparing base (43d2501) to head (2766889).

Files with missing lines Patch % Lines
...ture/ClientApp/src/app/core/permissions.service.ts 0.00% 3 Missing ⚠️
...re/ClientApp/src/app/shared/text/text.component.ts 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3051   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         559      559           
  Lines       32250    32268   +18     
  Branches     5240     5227   -13     
=======================================
+ Hits        26659    26675   +16     
- Misses       4809     4822   +13     
+ Partials      782      771   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
will require testing PR should not be merged until testers confirm testing is complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant