Do not use standardKeymap in vim mode #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard keymap conflicts with the vim mode, e.g. not allowing arrow keys to move through the vim commandline for `/` and `:` commands. The keys described in https://codemirror.net/docs/ref/#commands.standardKeymap seem to work just fine without it in vim mode. Fixes silverbulletmd#976
|
Alright, let's try, people will scream if this breaks stuff :) |
|
Uhh... screamer here. I don't know how I missed this, but this breaks the Return key for ordinary paragraphs (it does nothing in Insert mode now). Super weird. Workaround is hitting |
|
I'll move discussion back to #976. |
lutzky
added a commit
to lutzky/silverbullet
that referenced
this pull request
Nov 11, 2024
This is a workaround for replit/codemirror-vim#182 Fixes silverbulletmd#1145 (harder)
Merged
zefhemel
pushed a commit
that referenced
this pull request
Nov 11, 2024
This is a workaround for replit/codemirror-vim#182 Fixes #1145 (harder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard keymap conflicts with the vim mode, e.g. not allowing arrow keys to move through the vim commandline for
/and:commands. The keys described inhttps://codemirror.net/docs/ref/#commands.standardKeymap seem to work just fine without it in vim mode.
Fixes #976