Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Add entry about utf8mb4 encoding update to changelog #602

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

maxime-rainville
Copy link
Contributor

@maxime-rainville maxime-rainville commented Oct 19, 2024

Description

Add entry about utf8mb4 encoding update to changelog

Issues

Related PRs

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

@maxime-rainville
Copy link
Contributor Author

The linting is failing ... but because of the 5.3rc changelog.

en/08_Changelogs/6.0.0.md Outdated Show resolved Hide resolved
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@GuySartorelli GuySartorelli merged commit a0e3f11 into silverstripe:6 Oct 21, 2024
2 of 3 checks passed
@maxime-rainville maxime-rainville deleted the pulls/6/utf8mb4 branch October 22, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants