Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Use FieldValidators for FormFieldValidation #621

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as draft November 4, 2024 02:40
@emteknetnz emteknetnz force-pushed the pulls/6/form-field-valid branch 7 times, most recently from c27e818 to 74624d4 Compare November 12, 2024 23:13
@emteknetnz emteknetnz force-pushed the pulls/6/form-field-valid branch 2 times, most recently from 516d1fb to 53d015b Compare November 14, 2024 03:28
@emteknetnz emteknetnz marked this pull request as ready for review November 14, 2024 22:07
en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
en/08_Changelogs/6.0.0.md Outdated Show resolved Hide resolved
en/08_Changelogs/6.0.0.md Outdated Show resolved Hide resolved
en/08_Changelogs/6.0.0.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/form-field-valid branch 3 times, most recently from 7a78385 to 0d23732 Compare November 21, 2024 05:15
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes

en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
en/02_Developer_Guides/03_Forms/01_Validation.md Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/form-field-valid branch 5 times, most recently from a171679 to 788373a Compare November 26, 2024 04:30
@emteknetnz emteknetnz force-pushed the pulls/6/form-field-valid branch 2 times, most recently from e939717 to 5354d8c Compare November 27, 2024 21:39
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when all code PRs are merged

@emteknetnz emteknetnz force-pushed the pulls/6/form-field-valid branch from 5354d8c to f759d16 Compare December 1, 2024 21:58
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 47cff0e into silverstripe:6 Dec 2, 2024
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/form-field-valid branch December 2, 2024 20:13
emteknetnz added a commit to creative-commoners/developer-docs that referenced this pull request Dec 3, 2024
…orm-field-valid

DOC Use FieldValidators for FormFieldValidation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants