DOC Document new FormSchemaController #628
Conversation
GuySartorelli
force-pushed
the
pulls/6/formschema
branch
from
a36de86 to
8154fb2
Compare
| To view an example of a controller that follows these standards see [`LinkFieldController`](https://github.com/silverstripe/silverstripe-linkfield/blob/4/src/Controllers/LinkFieldController.php). | ||
| To view an example of a controller that follows these standards see [`LinkFieldController`](api:SilverStripe\LinkField\Controllers\LinkFieldController). |
There was a problem hiding this comment.
Unrelated change - link should be an API link
| > [!INFO] If you need to use GraphQL in your project for public-facing frontend schemas, you can still install and use the [`silverstripe/graphql`](https://github.com/silverstripe/silverstripe-graphql) module. | ||
| > [!NOTE] | ||
| > If you need to use GraphQL in your project for public-facing frontend schemas, you can still install and use the [`silverstripe/graphql`](https://github.com/silverstripe/silverstripe-graphql) module. |
There was a problem hiding this comment.
Unrelated - wasn't rendering correctly.
en/08_Changelogs/6.0.0.md
Outdated
| - [`CMSExternalLinksController`](api:SilverStripe\ExternalLinks\Controllers\CMSExternalLinksController) - used to be a direct subclass of [`Controller`](api:SilverStripe\Control\Controller). | ||
| As a result of these changes, the following classes have had their class hierarchy updated: | ||
|
|
||
| |class|old superclass|new superclass| |
There was a problem hiding this comment.
| |class|old superclass|new superclass| | |
| |Class|Old super class|New super class| |
There was a problem hiding this comment.
Would parent class be better than super class?
There was a problem hiding this comment.
The capitalisation isn't consistent with other tables in this page. Can you please look at the page in its rendered form (so you can see in context) and decide if you want the headers for all tables capitalised or lower-case? If you want them capitalised I'll update all the other tables as well.
Would parent class be better than super class?
They mean the same thing so I don't mind either way - just let me know whether you want that change or not.
We do already use "superclass" multiple times in the changelog, "super class" once, and "parent class" only once, in case that helps you decide.
There was a problem hiding this comment.
They should all be capitalized, looks wrong if it's lower case. Leave as super class if it's consistent
There was a problem hiding this comment.
I think it looks weird capitalized lol but I'll make the change.
GuySartorelli
force-pushed
the
pulls/6/formschema
branch
from
8154fb2 to
169ebe4
Compare
Issue
LeftAndMaininto its own abstract class silverstripe-admin#1762