Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Document deprecations as a result of refactoring ModalController #637

Merged
merged 1 commit into from
Nov 26, 2024
Merged

DOC Document deprecations as a result of refactoring ModalController #637

merged 1 commit into from
Nov 26, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli mentioned this pull request Nov 25, 2024
Closed
3 tasks
emteknetnz
emteknetnz requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict

@GuySartorelli GuySartorelli force-pushed the pulls/5/modalcontroller-deprecations branch from f195d84 to 7b03943 Compare November 26, 2024 03:34
@GuySartorelli
Copy link
Member Author

Resolved

@emteknetnz emteknetnz merged commit f0da28b into silverstripe:5 Nov 26, 2024
3 checks passed
@emteknetnz emteknetnz deleted the pulls/5/modalcontroller-deprecations branch November 26, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz