Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX JS Console errors and warnings #1699

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Mar 5, 2024

Description

SearchableDropdownField was tested with LinkField, Elemental and simply on a Page. There are not any related errors or warnings in dev or prod.

Parent issue

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Mar 5, 2024

There is still no formfield displaying. A field should be displayed (that's the main thing the issue is about - the console errors were just added to help diagnose what's causing the problem).

@GuySartorelli, I fixed it CMS 5.x-dev version (new env) and tested in different objects like Page, LinkField(FileLink) or Elemental. Everywhere I can create, save and update.

Screenshot 2024-03-05 at 11 01 42 AM

@GuySartorelli
Copy link
Member

Are you checking inside a modal, as per the reproduction steps in the issue?
Screencast from 05-03-24 16:44:43.webm

@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Mar 5, 2024

Thank you for the video. It helped.
Ha, but we are talking about two different fields. You show me issue with TreeDropdownField and I fixed some issues in SearchableDropdownField. If you click on "Details" you can work with fields, but by default (I don't know why?) this modal form is in read only state.
Probably, we should update styles for read only fields if they don't have a content.

Screen.Recording.2024-03-05.at.6.35.24.PM.mov

@GuySartorelli
Copy link
Member

Ahh, oops! The issue was meant to be about the fields I pointed at. I incorrectly identified them as SearchableDropdownField but turns out I was wrong.

I'll merge this since it resolves the console errors.
I'll leave it up to you to decide whether to close the attached issue and raise a separate one about TreeDropdownField not displaying, or whether you want to work on that as part of the existing issue.

@GuySartorelli GuySartorelli merged commit c74b777 into silverstripe:2.2 Mar 5, 2024
24 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.0/fix-js-console-errors branch March 5, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants