Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Use class name instead of self #1773

Merged
merged 1 commit into from
Jun 16, 2024
Merged

ENH Use class name instead of self #1773

merged 1 commit into from
Jun 16, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jun 5, 2024 •
edited
Loading

@emteknetnz emteknetnz mentioned this pull request Jun 5, 2024
Closed
5 tasks
@emteknetnz emteknetnz force-pushed the pulls/2.2/remove-self branch 3 times, most recently from 84293a0 to 25c51b3 Compare June 14, 2024 07:57
@emteknetnz emteknetnz force-pushed the pulls/2.2/remove-self branch from 25c51b3 to 7daeee4 Compare June 14, 2024 07:59
GuySartorelli
GuySartorelli approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bc0b13e into silverstripe:2.2 Jun 16, 2024
12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2.2/remove-self branch June 16, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli