FIX folders always go first when ordering #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Minor point that I think this is a bug fix not a feature re: the commit prefix |
dnsl48
force-pushed
the
pulls/1.2/folders-go-first
branch
from
4f200a3 to
b5a454b
Compare
true. fixed |
robbieaverill
changed the title
dnsl48
force-pushed
the
pulls/1.2/folders-go-first
branch
from
b5a454b to
bfa6733
Compare
6 tasks
unclecheese
approved these changes
Apr 18, 2019
| // see related issues for more details: | ||
| // - https://github.com/silverstripe/silverstripe-asset-admin/issues/820 | ||
| // - https://github.com/silverstripe/silverstripe-asset-admin/issues/893 | ||
| $field = $query->expressionForField(trim($field, '"')) ?: $field; |
There was a problem hiding this comment.
One of these issues is closed and the other is the one that is resolved by this PR. I'm going to remove these links from the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #893
Also fixes the original fluent issue (#820)
Notes