Merge pull request #166 from open-sausages/pulls/1/sort-it-out

BUG Keep folder Name and Title in sync on update
silverstripe · Oct 8, 2018 · 6d67489 · 6d67489
2 parents 787a48b + 1a08051
commit 6d67489
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/Folder.php b/src/Folder.php
@@ -90,6 +90,13 @@ public function onBeforeDelete()
         parent::onBeforeDelete();
     }
 
+    public function onBeforeWrite()
+    {
+        parent::onBeforeWrite();
+
+        $this->Title = $this->getField('Name');
+    }
+
     /**
      * Return the relative URL of an icon for this file type
      *

diff --git a/tests/php/FolderTest.php b/tests/php/FolderTest.php
@@ -293,6 +293,19 @@ public function testTitleTiedToName()
         $newFolder->Title = 'TestTitleWithIllegalCharactersCopiedToName <!BANG!>';
         $this->assertEquals($newFolder->Name, $newFolder->Title);
         $this->assertEquals($newFolder->Title, 'TestTitleWithIllegalCharactersCopiedToName <!BANG!>');
+
+        // Title should be populated from name on first write
+        $writeFolder = new Folder();
+        $writeFolder->Name = 'TestNameWrittenToTitle';
+        $writeFolder->write();
+        $newFolderWritten = Folder::get_one(Folder::class, "\"Title\" = 'TestNameWrittenToTitle'");
+        $this->assertNotNull($newFolderWritten);
+
+        // Title should be populated from name on subsequent writes
+        $writeFolder->Name = 'TestNameWrittenToTitleOnUpdate';
+        $writeFolder->write();
+        $newFolderWritten = Folder::get_one(Folder::class, "\"Title\" = 'TestNameWrittenToTitleOnUpdate'");
+        $this->assertNotNull($newFolderWritten);
     }
 
     public function testRootFolder()