Selenium2Driver screenshot functionality #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
requested changes
Nov 13, 2023
scott-nz
force-pushed
the
feature/selenium-screenshot-functionality
branch
from
c0a6e36 to
bade4dc
Compare
|
@emteknetnz rebased and target branch updated |
|
Cheers, this will auto-tag on the 4.11 branch shortly and auto-tag on the 5.0 branch within the next week, let me know if you need this on the 5.0 branch sooner (note: I forgot to approve PR before merging, though I meant to approve it first) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getScreenshot() function has been included in Selenium2Driver since the v1.0.3 tag (current tag v1.6.0) so the FacebookWebDriver instance check should no longer be required
https://github.com/minkphp/MinkSelenium2Driver/blob/5d27505f991763d1392030f99556debcba1abf2d/src/Selenium2Driver.php#L488