Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove broken icons from gridfield add button #736

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Remove broken icons from gridfield add button #736

merged 1 commit into from
Dec 20, 2023

Conversation

satrun77
Copy link
Contributor

@satrun77 satrun77 commented Dec 19, 2023 •
edited by GuySartorelli
Loading

From icon data attribute from grid field add button.

Issue

@satrun77 satrun77 mentioned this pull request Dec 19, 2023
Closed
@GuySartorelli
Copy link
Member

Thanks for submitting this fix.
Please retarget this PR to the 4.1 branch so it can be released as a patch.
You may need to reset your commits after retargetting the branch.

@satrun77 satrun77 changed the base branch from 4 to 4.1 December 19, 2023 01:08
@satrun77 satrun77 force-pushed the bugfix/icons-in-add-gridfield branch from 322dfcf to b2f0d12 Compare December 19, 2023 01:10
@GuySartorelli GuySartorelli self-assigned this Dec 19, 2023
GuySartorelli
GuySartorelli approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well locally. Thanks!

@GuySartorelli GuySartorelli merged commit 283ca6a into silverstripe:4.1 Dec 20, 2023
12 checks passed
@GuySartorelli GuySartorelli deleted the bugfix/icons-in-add-gridfield branch December 20, 2023 00:02
@GuySartorelli
Copy link
Member

This will be automatically tagged by GitHub actions.

@GuySartorelli GuySartorelli changed the title Remove icons from gridfield add button Remove broken icons from gridfield add button Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees

@GuySartorelli GuySartorelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satrun77 @GuySartorelli