Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix siteconfig behat test running on kitchen-sink #2959

Merged
merged 1 commit into from
Jun 10, 2024
Merged

MNT Fix siteconfig behat test running on kitchen-sink #2959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/behat/src/LoginContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use Page;
use PHPUnit\Framework\Assert;
use SilverStripe\BehatExtension\Context\LoginContext as BehatLoginContext;
use SilverStripe\SiteConfig\SiteConfig;

class LoginContext extends BehatLoginContext
{
Expand All @@ -26,7 +27,11 @@ public function pagesShouldBeEditableBy($negative, $permCode)
$password = 'Password!456';
$member = $this->generateMemberWithPermission($email, $password, $permCode);
$canEdit = strstr($negative ?? '', 'not') ? false : true;

// Flush the SiteConfig cache so that siteconfig behat tests that update a
// SiteConfig DataObject will not be referring to a stale verion of itself
// which can happen because SiteConfig::current_site_config() uses DataObject::get_one()
// which will caches its result by default
SiteConfig::current_site_config()->flushCache();
if ($canEdit) {
Assert::assertTrue($page->canEdit($member), 'The member can edit this page');
} else {
Expand Down
Loading