DEP Use PHPUnit 11 #3000
Merged
DEP Use PHPUnit 11 #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
3 times, most recently
from
cbbec51 to
d23c78c
Compare
emteknetnz
commented
Sep 10, 2024
| @@ -5,7 +5,7 @@ | |||
| use SilverStripe\CMS\Model\SiteTree; | |||
| use SilverStripe\Dev\TestOnly; | |||
|
|
|||
| class SiteTreeTest_NamespaceMapTest extends SiteTree implements TestOnly | |||
| class SiteTreeTest_NamespaceMapTestNode extends SiteTree implements TestOnly | |||
There was a problem hiding this comment.
Because this file ends in "Test" - phpunit though it was a test class and complained that it had no test cases. So I simply renamed it to match its $table_name
emteknetnz
commented
Sep 10, 2024
| @@ -5,7 +5,7 @@ | |||
| use SilverStripe\CMS\Controllers\ContentController; | |||
| use SilverStripe\Dev\TestOnly; | |||
|
|
|||
| class SiteTreeTest_NamespaceMapTestController extends ContentController implements TestOnly | |||
| class SiteTreeTest_NamespaceMapTestNodeController extends ContentController implements TestOnly | |||
There was a problem hiding this comment.
This was renamed to match the corresponding SiteTreeTest_NamespaceMapTestNode which was also renamed
2 tasks
GuySartorelli
approved these changes
Sep 17, 2024
emteknetnz
force-pushed
the
pulls/6/phpunit11
branch
from
d23c78c to
36686f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#305